Fix false positive for enum members shadowing base properties#20807
Open
emmanuel-ferdman wants to merge 1 commit intopython:masterfrom
Open
Fix false positive for enum members shadowing base properties#20807emmanuel-ferdman wants to merge 1 commit intopython:masterfrom
emmanuel-ferdman wants to merge 1 commit intopython:masterfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
- discord/enums.py:960: error: Incompatible types in assignment (expression has type "int", base class "Enum" defined the type as "str") [assignment]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
Defining an enum member called
valueornameusingauto()caused mypy to incorrectly report an incompatible types error, as if overriding the baseEnum.valueproperty. These are just regular enum members that happen to shadow the property name, not actual overrides. The fix skips the compatibility check for that case.Fixes #20247